Bought a gun with a Chinese Tasco 3-9X and I'm thinking of swapping it out for an old Weaver 2.5-8x made in El Paso. Yeah or nay?
The only 2.5-8x Weaver that I'm aware of is the V8 model that has the windage and elevation adjustments in the rear ring, sort of a poor man's version of the B&L Balvar series of externally adjusted scopes and mounts. That scope would be 60 or so years old and there have been a few improvements in optics since then.
I'm sure that you can find a newer used Weaver or Redfield or B&L on eBay. That said, it's your money, spend it however you want to.