Every time I think about trying to make homemade onion rings, I think about how good they usually are at Sonic, and never bother.
I swear I believe Sonic mixes a good shot of vanilla cake mix or something like it in their batter. There is a sweet, vanilla taste in there that I don't think comes from the onion itself. Other people may not like them but I have a huge sweet tooth and love those onion rings.
Their tater tots are great too, unless they fry them too long.