Sounds like a fair trade on the surface but still I'd suggest taking as much time as needed to deeper investigate possible legal and personal unforeseen pitfalls before I formally committed to anything binding.
The lake sounds nice but could come with it's own future issues as well.
Nothing against your current neighbor but good neighbors today may not always be so good or maybe not your neighbor later on.
